Skip to content

Changes to support NeMo Microservices v25.06#531

Merged
shivamerla merged 4 commits intoNVIDIA:mainfrom
shivamerla:update_eval_25_06
Jun 13, 2025
Merged

Changes to support NeMo Microservices v25.06#531
shivamerla merged 4 commits intoNVIDIA:mainfrom
shivamerla:update_eval_25_06

Conversation

@shivamerla
Copy link
Copy Markdown
Collaborator

@shivamerla shivamerla commented Jun 12, 2025

  • New evaluation images support (BFCL, Agentic Evaluation)
  • Remove the evaluation image validation markers (as some are optional across versions)
  • Update Unit tests
  • Customizer Config updates to make it compatible across both versions

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivamerla shivamerla changed the title Changes to support NeMo Evaluator 25.06 Changes to support NeMo Microservices v25.06 Jun 12, 2025
* New evaluation images support (BFCL, Agentic Evaluation)
* Remove the evaluation image validation markers (as some are optional across versions)
* Update Unit tests

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Comment thread api/apps/v1alpha1/nemo_evaluator_types.go
Comment thread internal/controller/nemocustomizer_controller.go
Comment thread internal/controller/nemocustomizer_controller.go Outdated
Comment thread internal/controller/nemocustomizer_controller.go Outdated
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Copy link
Copy Markdown
Collaborator

@varunrsekar varunrsekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla shivamerla merged commit bfe8ea0 into NVIDIA:main Jun 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants