Skip to content

Adding unit test for buildable support #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visheshtanksale merged 2 commits into from
Jun 30, 2025
Merged

Adding unit test for buildable support #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ff40f
Adding unit test for buildable support
visheshtanksale Jun 28, 2025
ca79ff8
Merge branch 'main' into buildable-profile
shivamerla Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/controller/nimbuild_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ func (r *NIMBuildReconciler) reconcileEngineBuild(ctx context.Context, nimBuild

logger.Info("Created pod for NIM Cache engine build", "pod", podName)
conditions.UpdateCondition(&nimBuild.Status.Conditions, appsv1alpha1.NimBuildConditionEngineBuildPodCreated, metav1.ConditionTrue, "EngineBuildPodCreated", "The pod to build engine has been created")
return nil
return r.updateNIMBuildState(ctx, nimBuild, appsv1alpha1.NimBuildStatusInProgress)
}

// Reconcile the job status
Expand Down Expand Up @@ -483,7 +483,7 @@ func (r *NIMBuildReconciler) reconcileEngineBuildPodStatus(ctx context.Context,

case pod.Status.Phase == corev1.PodFailed && !meta.IsStatusConditionTrue(nimBuild.Status.Conditions, appsv1alpha1.NimBuildConditionEngineBuildPodCompleted):
logger.Info("Failed to cache NIM, build pod failed", "pod", pod)
conditions.UpdateCondition(&nimBuild.Status.Conditions, appsv1alpha1.NimBuildConditionEngineBuildPodCreated, metav1.ConditionFalse, "PodFailed", "The pod to build engine has failed")
conditions.UpdateCondition(&nimBuild.Status.Conditions, appsv1alpha1.NimBuildConditionEngineBuildPodCompleted, metav1.ConditionFalse, "PodFailed", "The pod to build engine has failed")
return r.updateNIMBuildState(ctx, nimBuild, appsv1alpha1.NimBuildStatusFailed)

case !isPodReady(pod) && !meta.IsStatusConditionTrue(nimBuild.Status.Conditions, appsv1alpha1.NimBuildConditionEngineBuildPodCompleted):
Expand Down Expand Up @@ -939,7 +939,7 @@ func constructLocalManifestPodSpec(nimCache *appsv1alpha1.NIMCache, nimBuild *ap
{
Name: NIMBuildManifestContainerName,
Image: nimBuild.GetImage(),
Command: getNIMBuildSidecarCommand(),
Command: getNIMBuildLocalManifestPodCommand(),
SecurityContext: &corev1.SecurityContext{
AllowPrivilegeEscalation: ptr.To[bool](false),
Capabilities: &corev1.Capabilities{
Expand All @@ -962,7 +962,8 @@ func constructLocalManifestPodSpec(nimCache *appsv1alpha1.NIMCache, nimBuild *ap
return pod
}

func getNIMBuildSidecarCommand() []string {
// getNIMBuildLocalManifestPodCommand is the command to run in the local manifest pod.
func getNIMBuildLocalManifestPodCommand() []string {
return []string{
"sh",
"-c",
Expand All @@ -973,6 +974,7 @@ func getNIMBuildSidecarCommand() []string {
}
}

// createPod creates a pod in the cluster.
func (r *NIMBuildReconciler) createPod(ctx context.Context, pod *corev1.Pod) error {
// Create pod
err := r.Create(ctx, pod)
Expand All @@ -982,6 +984,7 @@ func (r *NIMBuildReconciler) createPod(ctx context.Context, pod *corev1.Pod) err
return nil
}

// updateManifestConfigMap updates the manifest ConfigMap in the cluster with the local manifest data.
func (r *NIMBuildReconciler) updateManifestConfigMap(ctx context.Context, nimCache *appsv1alpha1.NIMCache, manifestData *nimparser.NIMManifestInterface) error {
// Convert manifestData to YAML
manifestBytes, err := yaml.Marshal(manifestData)
Expand Down
Loading