Skip to content

Add unit tests to KServe platform deployment for NIMService#567

Merged
shivamerla merged 1 commit intoNVIDIA:mainfrom
xieshenzh:nim-kserve-test
Jul 15, 2025
Merged

Add unit tests to KServe platform deployment for NIMService#567
shivamerla merged 1 commit intoNVIDIA:mainfrom
xieshenzh:nim-kserve-test

Conversation

@xieshenzh
Copy link
Copy Markdown
Contributor

Changes:

  • Add unit tests to KServe platform deployment for NIMService

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jul 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xieshenzh xieshenzh force-pushed the nim-kserve-test branch 3 times, most recently from 465edb7 to 628c9f5 Compare July 10, 2025 18:58
@shivamerla
Copy link
Copy Markdown
Collaborator

thanks @xieshenzh please mark the PR as ready we can merge this.

shivamerla
shivamerla previously approved these changes Jul 11, 2025
Copy link
Copy Markdown
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieshenzh xieshenzh force-pushed the nim-kserve-test branch 2 times, most recently from ab912b6 to 896bf25 Compare July 14, 2025 17:18
@xieshenzh xieshenzh changed the title [WIP] Add unit tests to KServe platform deployment for NIMService Add unit tests to KServe platform deployment for NIMService Jul 14, 2025
@xieshenzh xieshenzh marked this pull request as ready for review July 14, 2025 18:24
@xieshenzh
Copy link
Copy Markdown
Contributor Author

@shivamerla The PR is ready for review. Thanks.

@shivamerla shivamerla enabled auto-merge (rebase) July 15, 2025 15:08
@shivamerla
Copy link
Copy Markdown
Collaborator

@xieshenzh can you fix the linter issue please.

Signed-off-by: Xieshen Zhang <xiezhang@redhat.com>
auto-merge was automatically disabled July 15, 2025 15:37

Head branch was pushed to by a user without write access

@xieshenzh
Copy link
Copy Markdown
Contributor Author

@shivamerla I have updated the PR. Thanks.

@shivamerla shivamerla enabled auto-merge (rebase) July 15, 2025 16:24
@shivamerla shivamerla merged commit 864528f into NVIDIA:main Jul 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants