Should give precedence to user provided env var on Universal NIM Service#577
Merged
visheshtanksale merged 2 commits intoNVIDIA:mainfrom Jul 15, 2025
Merged
Conversation
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
visheshtanksale
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011 and
varunrsekar
as code owners
Collaborator
|
Thanks. This LGM... There's a couple other discrepancies as well. Can you fix those?
|
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
shivamerla
approved these changes
Jul 15, 2025
Collaborator
shivamerla
left a comment
shivamerla
left a comment
There was a problem hiding this comment.
Good catch @visheshtanksale
aryangorwade
pushed a commit
to aryangorwade/k8s-nim-operator
that referenced
this pull request
Jul 16, 2025
…ice (NVIDIA#577) Signed-off-by: Aryan <gorwadearyan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user provides Env Vars on NIMService then those env vars should have precedence.