Skip to content

Removing validation check on PVC field #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visheshtanksale merged 1 commit into from
Jul 16, 2025
Merged

Removing validation check on PVC field #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/apps/v1alpha1/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,6 @@ type HFSecret struct {
}

// PersistentVolumeClaim defines the attributes of PVC.
// +kubebuilder:validation:XValidation:rule="!has(self.create) || !self.create || (has(self.size) && self.size != \"\")", message="size is required for pvc creation"
// +kubebuilder:validation:XValidation:rule="!has(self.create) || !self.create || (has(self.volumeAccessMode) && self.volumeAccessMode != \"\")", message="volumeAccessMode is required for pvc creation"
type PersistentVolumeClaim struct {
// Create specifies whether to create a new PersistentVolumeClaim (PVC).
// If set to false, an existing PVC must be referenced via the `Name` field.
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nemocustomizers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,13 +2080,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
networkConfig:
description: NetworkConfig is the network configuration for multi-node
training
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nemodatastores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,13 +815,6 @@ spec:
PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size) && self.size
!= "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
replicas:
default: 1
minimum: 1
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nemoguardrails.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
x-kubernetes-validations:
- message: Cannot set both ConfigMap and PVC in ConfigStore
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nimcaches.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
tolerations:
description: Tolerations for running the job to cache the NIM model
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nimpipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2352,13 +2352,6 @@ spec:
mode of the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should
be mounted as read-only
Expand Down
7 changes: 0 additions & 7 deletions bundle/manifests/apps.nvidia.com_nimservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2263,13 +2263,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should be mounted
as read-only
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nemocustomizers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,13 +2080,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
networkConfig:
description: NetworkConfig is the network configuration for multi-node
training
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nemodatastores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,13 +815,6 @@ spec:
PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size) && self.size
!= "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
replicas:
default: 1
minimum: 1
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nemoguardrails.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
x-kubernetes-validations:
- message: Cannot set both ConfigMap and PVC in ConfigStore
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nimcaches.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
tolerations:
description: Tolerations for running the job to cache the NIM model
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nimpipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2352,13 +2352,6 @@ spec:
mode of the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should
be mounted as read-only
Expand Down
7 changes: 0 additions & 7 deletions config/crd/bases/apps.nvidia.com_nimservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2263,13 +2263,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should be mounted
as read-only
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nemocustomizers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,13 +2080,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
networkConfig:
description: NetworkConfig is the network configuration for multi-node
training
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nemodatastores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,13 +815,6 @@ spec:
PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size) && self.size
!= "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
replicas:
default: 1
minimum: 1
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nemoguardrails.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
x-kubernetes-validations:
- message: Cannot set both ConfigMap and PVC in ConfigStore
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimcaches.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,13 +472,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
type: object
tolerations:
description: Tolerations for running the job to cache the NIM model
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimpipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2352,13 +2352,6 @@ spec:
mode of the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should
be mounted as read-only
Expand Down
7 changes: 0 additions & 7 deletions deployments/helm/k8s-nim-operator/crds/apps.nvidia.com_nimservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2263,13 +2263,6 @@ spec:
the PVC
type: string
type: object
x-kubernetes-validations:
- message: size is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.size)
&& self.size != "")'
- message: volumeAccessMode is required for pvc creation
rule: '!has(self.create) || !self.create || (has(self.volumeAccessMode)
&& self.volumeAccessMode != "")'
readOnly:
description: ReadOnly mode indicates if the volume should be mounted
as read-only
Expand Down
Loading