Merged
Conversation
e6faaf6 to
6c2d265
Compare
fb26486 to
f543116
Compare
shivamerla
reviewed
Aug 12, 2025
3ff51d7 to
289f539
Compare
7e5cbbe to
2765332
Compare
shivamerla
approved these changes
Aug 13, 2025
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros:
The PR creates a httproutes.gateway.networking.k8s.io CRD if
.spec.expose.httpRouteis specified for NIMService and NeMo Microservices.Cons:
Pre-requisites
Gatewayobject with allowable hostnames must be defined. Below is a sampleGatewaypowered by Istio.Sample NIMService object with HTTPRoute coupling
Below is a sample NIMService object that routes the domain
foobar.nimits backend Service object.Note that
.spec.expose.httpRouteis new.Sample NeMo Microservice with HTTPRoute coupling
Below is a sample NeMoDatastore object that routes the domain
datastore.nemoits backend Service object.