Merged
Conversation
Collaborator
shivamerla
commented
Aug 14, 2025
shivamerla
commented
- Error out if there is a conflict with the NIM services in the pipeline vs pre-existing service
- Clenup NIM service if the spec is removed from the pipeline
shivamerla
requested review from
ArangoGutierrez,
shengnuo,
slu2011,
varunrsekar and
visheshtanksale
as code owners
* Error out if there is a conflict with the NIM services in the pipeline vs pre-existing service * Clenup NIM service if the spec is removed from the pipeline
shivamerla
force-pushed
the
nimpipeline_fixes
branch
from
ed7d2a1 to
838de24
Compare
varunrsekar
previously approved these changes
Aug 14, 2025
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
varunrsekar
reviewed
Aug 15, 2025
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
varunrsekar
approved these changes
Aug 15, 2025
Collaborator
varunrsekar
left a comment
varunrsekar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.