-
Notifications
You must be signed in to change notification settings - Fork 37
Enable Webhook Warning messages, add Gateway API integration and simply Ingress integration #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2025
bca6f48 to
d77416c
Compare
da5bb4c to
5c6a8d7
Compare
shivamerla
reviewed
Sep 8, 2025
shivamerla
reviewed
Sep 8, 2025
23d9a6b to
f627a22
Compare
shivamerla
reviewed
Sep 8, 2025
shivamerla
previously approved these changes
Sep 9, 2025
Collaborator
shivamerla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
varunrsekar
reviewed
Sep 9, 2025
f627a22 to
f3b31cc
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
…erator create HTTPRoute objects from Gateway API Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
f3b31cc to
a60f1d7
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
62d72b5 to
99f23ee
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
b6a7469 to
e3f16d3
Compare
shivamerla
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field under
.spec.routerfor NIMService and NeMo Microservices, for integrating with Ingress or Gateway API.The created routing object will have the hostname in the format
<.metadata.name>.<.metadata.namespace><.spec.router.hostDomainName>Gateway API
Sample
routerfor Gateway API integrationOnly HTTPRoutes is supported from Gateway API.
GRPCRoutes is pending.
Ingress
Sample
routerfor Ingress integrationDeprecation
NIMService.spec.expose.ingresswill be deprecated. The field is present, a warning message from webhook will be display.The deprecated fields will remain for sometimes for backward compatibility.