Skip to content

Conversation

@shengnuo
Copy link
Collaborator

@shengnuo shengnuo commented Aug 29, 2025

This PR introduces a new field under .spec.router for NIMService and NeMo Microservices, for integrating with Ingress or Gateway API.

The created routing object will have the hostname in the format <.metadata.name>.<.metadata.namespace><.spec.router.hostDomainName>

Gateway API

Sample router for Gateway API integration

  router:
    gateway:
      namespace: nemo
      name: istio-gateway
    hostDomainName: foobar.com

Only HTTPRoutes is supported from Gateway API.
GRPCRoutes is pending.

Ingress

Sample router for Ingress integration

router:
  ingress:
    ingressClass: nginx
    tlsSecretName: my-secret
  hostDomainName: foobar.com

Deprecation

NIMService.spec.expose.ingress will be deprecated. The field is present, a warning message from webhook will be display.

The deprecated fields will remain for sometimes for backward compatibility.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shengnuo shengnuo force-pushed the simplify-route-2 branch 3 times, most recently from bca6f48 to d77416c Compare September 5, 2025 19:58
@shengnuo shengnuo marked this pull request as ready for review September 5, 2025 20:02
@shengnuo shengnuo changed the title Add Gateway API integration and simply Ingress integration Enable Webhook Warning messages, add Gateway API integration and simply Ingress integration Sep 5, 2025
@shengnuo shengnuo force-pushed the simplify-route-2 branch 2 times, most recently from da5bb4c to 5c6a8d7 Compare September 5, 2025 20:13
@shengnuo shengnuo force-pushed the simplify-route-2 branch 2 times, most recently from 23d9a6b to f627a22 Compare September 8, 2025 21:27
shivamerla
shivamerla previously approved these changes Sep 9, 2025
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Sheng Lin <shelin@nvidia.com>
…erator create HTTPRoute objects from Gateway API

Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
@shengnuo shengnuo force-pushed the simplify-route-2 branch 2 times, most recently from 62d72b5 to 99f23ee Compare September 9, 2025 19:32
shengnuo and others added 3 commits September 9, 2025 15:52
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@shengnuo shengnuo merged commit 3ff2e94 into NVIDIA:main Sep 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants