Consolidate samples for deployment of#649
Merged
shivamerla merged 7 commits intoNVIDIA:mainfrom Sep 2, 2025
Merged
Conversation
Collaborator
shivamerla
commented
Sep 2, 2025
shivamerla
commented
- LLM Specific NIMs
- Multi LLM NIMs
- NIMs on Kserve vs Standalone deployment
- NIMs with Advanced features (DRA, Multi-Node etc)
- Pipeline of NIMs for RAG, Guardrails
* LLM Specific NIMs * Multi LLM NIMs * NIMs on Kserve vs Standalone deployment * NIMs with Advanced features (DRA, Multi-Node etc) * Pipeline of NIMs for RAG, Guardrails Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
shivamerla
requested review from
ArangoGutierrez,
shengnuo,
slu2011,
varunrsekar and
visheshtanksale
as code owners
mkhaas
reviewed
Sep 2, 2025
mkhaas
reviewed
Sep 2, 2025
mkhaas
reviewed
Sep 2, 2025
mkhaas
reviewed
Sep 2, 2025
mkhaas
reviewed
Sep 2, 2025
config/samples/nim/serving/advanced/multi-node/multi-node-nimservice-rdma.yaml
Show resolved
Hide resolved
mkhaas
reviewed
Sep 2, 2025
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
varunrsekar
reviewed
Sep 2, 2025
Collaborator
varunrsekar
left a comment
varunrsekar
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks for doing this!
One comment:
Can you flatten the caching dirs for ngc?
Eg:
- config/samples/nim/caching/ngc/
- config/samples/nim/caching/ngc-mirror/
- config/samples/nim/caching/ngc-mirror/https
- config/samples/nim/caching/ngc-mirror/jfrog
- ...
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
varunrsekar
previously approved these changes
Sep 2, 2025
Collaborator
varunrsekar
left a comment
varunrsekar
left a comment
There was a problem hiding this comment.
LGTM! just 1 comment...
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
varunrsekar
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.