Using secret names and custom issuer with cert-manager#659
Merged
shivamerla merged 2 commits intoNVIDIA:mainfrom Sep 16, 2025
Merged
Conversation
shivamerla
reviewed
Sep 9, 2025
Collaborator
|
Thanks @aryangorwade this looks good to me. |
shivamerla
previously approved these changes
Sep 9, 2025
33832a8 to
6cc24bb
Compare
Collaborator
Author
|
@shivamerla should I set admissionController.enabled to true or false by default. Previously when you approved it was true |
Collaborator
|
since the release branch for 3.0 is cut, we can enable this by default and add a dependency on cert-manager with next release. |
Signed-off-by: Aryan <[email protected]>
6cc24bb to
3389e9e
Compare
shivamerla
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented webhook signing configuration in a similar manner to DRA driver:
This change introduces a new Helm chart value to supply a CA bundle (e.g., from ca.crt) directly into the ValidatingWebhookConfiguration when cert-manager is not used. Secret must be created with tls.key and tls.crt.
This allows clusters without automated CA injection to configure the webhook manually and ensure proper TLS verification.