-
Notifications
You must be signed in to change notification settings - Fork 37
Integrate GRPCRoute into NIMService #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0980c4a to
60b4806
Compare
shivamerla
reviewed
Sep 17, 2025
shivamerla
reviewed
Sep 17, 2025
983f508 to
46d8f28
Compare
shivamerla
reviewed
Sep 17, 2025
46d8f28 to
7389958
Compare
Signed-off-by: Sheng Lin <shelin@nvidia.com>
…o CRs Signed-off-by: Sheng Lin <shelin@nvidia.com>
Signed-off-by: Sheng Lin <shelin@nvidia.com>
…messages when router is enabled but the exposed service is of type LoadBalancer Signed-off-by: Sheng Lin <shelin@nvidia.com>
3ce7469 to
4d5c504
Compare
shivamerla
previously approved these changes
Oct 19, 2025
Collaborator
shivamerla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks @shengnuo Now API looks much better.
Collaborator
|
/ok to test 4d5c504 |
…NeMo Signed-off-by: Sheng Lin <shelin@nvidia.com>
mkhaas
reviewed
Oct 20, 2025
shivamerla
previously approved these changes
Oct 24, 2025
Collaborator
|
/ok to test 599b83e |
Collaborator
|
/ok to test 8cbfd1c |
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
Collaborator
|
/ok to test b1701d9 |
shivamerla
approved these changes
Nov 6, 2025
Collaborator
|
/ok to test 012c858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds integrates NIMServices with GRPCRoute.
.spec.router.gateway.grpcRoutesEnabled.spec.expose.service.grpcPort. If it's not specified, the default50051port is used..spec.router.hostnameSample Istio Gateway (HTTP + gRPC on same hostname)