Change logic for checking KServe deployment mode to address compatibility issue with ODH 3.0 #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieshenzh
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
varunrsekar and
visheshtanksale
as code owners
varunrsekar
reviewed
Jan 23, 2026
Collaborator
varunrsekar
left a comment
varunrsekar
left a comment
There was a problem hiding this comment.
@xieshenzh Thanks for addressing this! Overall change makes sense to me. Had some comments...
internal/webhook/apps/v1alpha1/nimservice_webhook_validation_helper.go
Outdated
Show resolved
Hide resolved
internal/webhook/apps/v1alpha1/nimservice_webhook_validation_helper.go
Outdated
Show resolved
Hide resolved
…ow backward compatibility with ODH Signed-off-by: Xieshen Zhang <xiezhang@redhat.com>
Signed-off-by: Xieshen Zhang <xiezhang@redhat.com>
…rve RawDeployment mode Signed-off-by: Xieshen Zhang <xiezhang@redhat.com>
Signed-off-by: Xieshen Zhang <xiezhang@redhat.com>
xieshenzh
force-pushed
the
kserve-deploymentmode
branch
from
0e7b790 to
4ef1797
Compare
Contributor
Author
|
@varunrsekar I have addressed the comments. Please take a look. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create this PR to fix #735
ODH 3.0 still uses deployment mode
RawDeployment(default deployment mode) andServerless.This PR also addresses the compatibility issue with ODH 3.0 .