Skip to content

fix(msfs): interpret AIStore Atime as nanoseconds, not microseconds#108

Open
joshuarobinson wants to merge 1 commit into
mainfrom
fix/mr733-aistore-atime-nanoseconds
Open

fix(msfs): interpret AIStore Atime as nanoseconds, not microseconds#108
joshuarobinson wants to merge 1 commit into
mainfrom
fix/mr733-aistore-atime-nanoseconds

Conversation

@joshuarobinson

@joshuarobinson joshuarobinson commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

AIStore's ObjAttrs.Atime is an int64 count of nanoseconds since the Unix epoch (per github.com/NVIDIA/aistore/cmn objattrs.go). statFile converted it with time.UnixMicro, treating the value as microseconds, which made every reported modification time ~1000x too large (tens of thousands of years in the future). Use time.Unix(0, props.Atime) to match the rest of the codebase.

https://github.com/NVIDIA/aistore/blob/main/cmn/objattrs.go#L84

Found in merged MR !733.

Checklist

  • Development PR
    • .release_notes/.unreleased.md
      • Notable changes to the client (i.e. not related to tooling, CI/CD, etc.) from this PR have been added.
  • Release PR
    • CI/CD
      • The default branch pipelines are passing in both GitHub + GitLab (latter for SwiftStack E2E tests).
    • multi-storage-client/pyproject.toml
      • The package version has been bumped.
    • .release_notes/.unreleased.md
      • This file's contents have been moved into a .release_notes/{bumped package version}.md file.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected file modification time handling for AIStore-backed files, improving timestamp accuracy and consistency.

AIStore's ObjAttrs.Atime is an int64 count of nanoseconds since the Unix
epoch (per github.com/NVIDIA/aistore/cmn objattrs.go). statFile converted
it with time.UnixMicro, treating the value as microseconds, which made
every reported modification time ~1000x too large (tens of thousands of
years in the future). Use time.Unix(0, props.Atime) to match the rest of
the codebase.

https://github.com/NVIDIA/aistore/blob/main/cmn/objattrs.go#L84

Found in merged MR !733.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@joshuarobinson
joshuarobinson requested a review from a team July 14, 2026 13:57
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1f280680-67cf-4b91-88dd-a4afe0e05d21

📥 Commits

Reviewing files that changed from the base of the PR and between d72a5de and 2b9a287.

📒 Files selected for processing (1)
  • multi-storage-file-system/backend_aistore.go

📝 Walkthrough

Walkthrough

Changes

AiStore metadata

Layer / File(s) Summary
File timestamp conversion
multi-storage-file-system/backend_aistore.go
statFile converts props.Atime with time.Unix(0, props.Atime) instead of time.UnixMicro(props.Atime).

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: ankitmaster08

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change by correcting AIStore Atime handling from microseconds to nanoseconds.
Description check ✅ Passed The description explains the fix, gives context, and includes the checklist, but it omits the explicit Relates to/Closes task line.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mr733-aistore-atime-nanoseconds

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant