fix(msfs): prepend backend prefix to startAfter in GCS/AIStore listOb…#116
fix(msfs): prepend backend prefix to startAfter in GCS/AIStore listOb…#116joshuarobinson wants to merge 1 commit into
Conversation
…jects The GCS and AIStore listObjects implementations set the paging start-bound (StartOffset / StartAfter) to the raw prefix-relative startAfter key, while the query Prefix is prefixed with backend.prefix and returned object paths are stripped of backend.prefix. When a backend prefix is configured, the start bound was therefore compared against full (prefixed) object names using a prefix-relative key, so the filter was effectively ignored and pagination/resume was broken. This matches the S3 backend, which correctly uses backend.prefix + startAfter. Found in merged MR !927. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAIStore and GCS object listing cursors now prepend each backend’s configured prefix to the provided ChangesPrefix-aware object listing
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
…jects
The GCS and AIStore listObjects implementations set the paging start-bound (StartOffset / StartAfter) to the raw prefix-relative startAfter key, while the query Prefix is prefixed with backend.prefix and returned object paths are stripped of backend.prefix. When a backend prefix is configured, the start bound was therefore compared against full (prefixed) object names using a prefix-relative key, so the filter was effectively ignored and pagination/resume was broken. This matches the S3 backend, which correctly uses backend.prefix + startAfter.
Found in merged MR !927.
Checklist
.release_notes/.unreleased.mdmulti-storage-client/pyproject.toml.release_notes/.unreleased.md.release_notes/{bumped package version}.mdfile.Summary by CodeRabbit