net_ib: add missing break in printIbWcStatusHint switch - #2265
Open
EylonKrause wants to merge 1 commit into
Open
net_ib: add missing break in printIbWcStatusHint switch#2265EylonKrause wants to merge 1 commit into
EylonKrause wants to merge 1 commit into
Conversation
The IBV_WC_LOC_PROT_ERR, IBV_WC_WR_FLUSH_ERR and IBV_WC_RETRY_EXC_ERR cases fell through, so a single completion error printed the hints for its own status plus every status below it (e.g. a protection error also told the user to raise NCCL_IB_TIMEOUT). Add break; to each case so only the matching hint is printed. Signed-off-by: EylonKrause <eylon1909@gmail.com>
Author
|
Disclosure: this contribution was authored with an AI coding assistant (Claude) and reviewed before submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
printIbWcStatusHintis aswitchon the IB work-completion status whoseIBV_WC_LOC_PROT_ERR,IBV_WC_WR_FLUSH_ERRandIBV_WC_RETRY_EXC_ERRcases lack abreak. Because they fall through, a single completion error prints its own hint plus the hints of every case below it — e.g. a local protection error (IBV_WC_LOC_PROT_ERR) also advises that "NCCL_IB_TIMEOUT is set too short", which is unrelated and misleading when debugging.Related Issues
None.
Changes & Impact
src/transport/net_ib/common.h(printIbWcStatusHint): addbreak;to each of the three cases so only the hint matching the actual completion status is printed. Diagnostic output only; no behavior change beyond the log text. Non-breaking.Performance Impact
None.
Testing
make src.build;all_reduce_perfregression:Out of bounds values : 0 OK.break;; the fix limits each completion status to its own hint.