fix(api-db): use inet cast instead of bigint for IPv4 resource pool min/max#584
Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(api-db): use inet cast instead of bigint for IPv4 resource pool min/max#584chet wants to merge 1 commit intoNVIDIA:mainfrom
chet wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-17 00:23:25 UTC | Commit: 0761ded |
🛡️ Vulnerability Scan🚨 Found 72 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-17 00:23:31 UTC | Commit: 0761ded |
rwthompsonii
approved these changes
Mar 17, 2026
chet
force-pushed
the
bug_5986950
branch
2 times, most recently
from
a73b5f9 to
820163a
Compare
bcavnvidia
approved these changes
Mar 17, 2026
…in/max This addresses NVIDIA#583. It looks like the bug was introduced in NVIDIA#224. The PREVIOUS code correctly used inet for the IPv4 query. When NVIDIA#224 rewrote the all() function to add auto-assign support, both the query_int and query_ipv4 subqueries were written with value::bigint. I think it was just a copy/paste and IPv4 was supposed to stay ::inet. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #583.
It looks like the bug was introduced in #224.
The PREVIOUS code correctly used inet for the IPv4 query. When #224 rewrote the
all()function to add auto-assign support, both thequery_intandquery_ipv4subqueries were written withvalue::bigint. I think it was just a copy/paste and IPv4 was supposed to stay::inet.Test added. We had/have tests for the IPv6 side, but not IPv4.
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes