Skip to content

chore: Update Core proto snapshot for REST components#251

Draft
thossain-nv wants to merge 4 commits intomainfrom
chore/update-core-proto
Draft

chore: Update Core proto snapshot for REST components#251
thossain-nv wants to merge 4 commits intomainfrom
chore/update-core-proto

Conversation

@thossain-nv
Copy link
Contributor

Description

Takes a snapshot of the latest Core proto and genereates protobuf.

TODO

  • Remove Site Agent code referencing previously deprecated/now removed proto methods
  • Identify newly deprecated proto attribute/methods and generate action items

Type of Change

  • Chore - Modification or removal of existing functionality (chore:)

Services Affected

  • API - API models or endpoints updated
  • Workflow - Workflow service updated
  • DB - DB DAOs or migrations updated
  • Site Manager - Site Manager updated
  • Cert Manager - Cert Manager updated
  • Site Agent - Site Agent updated
  • RLA - RLA service updated
  • Powershelf Manager - Powershelf Manager updated
  • NVSwitch Manager - NVSwitch Manager updated

Related Issues (Optional)

None

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

None

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@thossain-nv thossain-nv marked this pull request as draft March 13, 2026 01:34
@github-actions
Copy link

github-actions bot commented Mar 13, 2026

Test Results

   14 files  ±    0    145 suites  +7   3m 13s ⏱️ - 4m 44s
1 742 tests  - 6 329  1 669 ✅  - 6 402  0 💤 ±0  0 ❌ ±0  73 🔥 +73 
1 746 runs   - 6 325  1 669 ✅  - 6 402  0 💤 ±0  0 ❌ ±0  77 🔥 +77 

For more details on these errors, see this check.

Results for commit 600dd39. ± Comparison against base commit 0fffc26.

This pull request removes 6402 and adds 73 tests. Note that renamed tests count towards both.
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestMetricsConfig
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestMetricsConfig/initialize_Metrics_config
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewConfig
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewConfig/initialize_config
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewDBConfig
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewDBConfig/initialize_database_config
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewTemporalConfig
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ TestNewTemporalConfig/initialize_Temporal_config
github.com/nvidia/bare-metal-manager-rest/api/internal/server ‑ Test_Audit
github.com/nvidia/bare-metal-manager-rest/api/internal/server ‑ Test_InitAPIServer
…
github.com/nvidia/bare-metal-manager-rest/api/cmd/api ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/internal/config ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/internal/server ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/api ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/api/handler ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/api/handler/util/common ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/api/model ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/api/model/util ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/client/site ‑ Failure
github.com/nvidia/bare-metal-manager-rest/api/pkg/middleware ‑ Failure
…

♻️ This comment has been updated with latest results.

@thossain-nv thossain-nv force-pushed the chore/update-core-proto branch from d592982 to 600dd39 Compare March 13, 2026 01:40
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e95b699c-dc66-4cc9-b853-9fc109d21f1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-core-proto
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-03-13 01:41:04 UTC | Commit: 600dd39

@github-actions
Copy link

🛡️ Vulnerability Scan

🚨 Found 64 vulnerability(ies)
📊 vs main: 64 (no change)

Severity Breakdown:

  • 🔴 Critical/High: 64
  • 🟡 Medium: 0
  • 🔵 Low/Info: 0

🔗 View full details in Security tab

🕐 Last updated: 2026-03-13 01:42:36 UTC | Commit: 600dd39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant