Conversation
Signed-off-by: Peter Gambrill <pgambrill@nvidia.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request rebrand the repository from "NVIDIA Bare Metal Manager" to "NCX Infra Controller" across documentation, issue templates, and README files. All references to the old product name and repository path (bare-metal-manager-rest) are systematically replaced with the new naming (ncx-infra-controller-rest). No functional code changes are introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-16 21:20:16 UTC | Commit: 2067fe9 |
🛡️ Vulnerability Scan🚨 Found 64 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-16 21:20:26 UTC | Commit: 2067fe9 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 119-120: The README contains a mismatched directory name: after
cloning "ncx-infra-controller-rest" the next command uses "cd carbide-rest"
which will fail; update the second command to change into the cloned directory
by replacing "cd carbide-rest" with "cd ncx-infra-controller-rest" (or
alternatively change the clone URL to include "carbide-rest" if that's intended)
so the two commands reference the same repository name.
In `@openapi/README.md`:
- Around line 6-8: The README title and first sentence still use "NVIDIA Bare
Metal REST OpenAPI Schema" while the repo URL uses ncx-infra-controller-rest;
update the title string ("NVIDIA Bare Metal REST OpenAPI Schema") and the
description sentence that mentions "OpenAPI schema for NVIDIA Bare Metal REST
endpoints" to the new naming (e.g., "NCX Infra Controller OpenAPI Schema" and
"OpenAPI schema for NCX Infra Controller REST endpoints") so the text matches
the repository URL and naming convention.
In `@README.md`:
- Line 14: Replace the incorrect capitalization "Github pages" with the official
"GitHub pages" in the README line that reads "View latest OpenAPI schema on
Github pages" so the sentence becomes "View latest OpenAPI schema on GitHub
pages"; update any identical occurrences of the string "Github pages" in the
README to "GitHub pages" to ensure consistent, correct branding.
In `@rla/README.md`:
- Line 171: The README import example uses the wrong module path
"github.com/nvidia/ncx-infra-controller-rest"; update it to match the project's
actual module path declared in go.mod and used across sources
("github.com/nvidia/bare-metal-manager-rest") or alternatively change all go.mod
module declarations and every import to the new path; locate the inconsistent
string in the README (the import line referencing psmapi) and either replace
that import to "github.com/nvidia/bare-metal-manager-rest/..." to match existing
imports, or perform a repository-wide refactor updating go.mod files and all
import statements to the new module path so builds and imports are consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b30f1f4a-d08a-44b0-a02e-aedc9ab361ad
📒 Files selected for processing (14)
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/documentation-request.md.github/ISSUE_TEMPLATE/feature_request.md.github/ISSUE_TEMPLATE/submit-question.mdCODE_OF_CONDUCT.mdCONTRIBUTING.mdREADME.mdauth/README.mdcli/README.mdopenapi/README.mdrla/README.mdrla/docs/component-manager-architecture.mdrla/internal/task/executor/temporalworkflow/README.mdsdk/simple/README.md
| git clone https://github.com/<your-username>/ncx-infra-controller-rest.git | ||
| cd carbide-rest |
There was a problem hiding this comment.
Fix directory name after clone command.
Line 119 clones ncx-infra-controller-rest, but Line 120 still changes into carbide-rest, which will fail for new contributors.
Suggested doc fix
git clone https://github.com/<your-username>/ncx-infra-controller-rest.git
-cd carbide-rest
+cd ncx-infra-controller-rest📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| git clone https://github.com/<your-username>/ncx-infra-controller-rest.git | |
| cd carbide-rest | |
| git clone https://github.com/<your-username>/ncx-infra-controller-rest.git | |
| cd ncx-infra-controller-rest |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CONTRIBUTING.md` around lines 119 - 120, The README contains a mismatched
directory name: after cloning "ncx-infra-controller-rest" the next command uses
"cd carbide-rest" which will fail; update the second command to change into the
cloned directory by replacing "cd carbide-rest" with "cd
ncx-infra-controller-rest" (or alternatively change the clone URL to include
"carbide-rest" if that's intended) so the two commands reference the same
repository name.
| # NVIDIA Bare Metal REST OpenAPI Schema | ||
|
|
||
| This repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/bare-metal-manager-rest/ | ||
| This repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/ncx-infra-controller-rest/ |
There was a problem hiding this comment.
Incomplete renaming - title and description still reference old name.
While the URL has been updated to ncx-infra-controller-rest on line 8, the title (line 6) and description text still reference "NVIDIA Bare Metal REST". This creates an inconsistency where the documentation describes itself differently than the repository it references.
Consider updating the title and description to match the new naming scheme, e.g., "NCX Infra Controller OpenAPI Schema".
📝 Suggested update for consistency
-# NVIDIA Bare Metal REST OpenAPI Schema
+# NCX Infra Controller REST OpenAPI Schema
-This repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/ncx-infra-controller-rest/
+This repo contains OpenAPI schema for NCX Infra Controller REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/ncx-infra-controller-rest/📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # NVIDIA Bare Metal REST OpenAPI Schema | |
| This repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/bare-metal-manager-rest/ | |
| This repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/ncx-infra-controller-rest/ | |
| # NCX Infra Controller REST OpenAPI Schema | |
| This repo contains OpenAPI schema for NCX Infra Controller REST endpoints. Redoc rendered latest version can be viewed at https://nvidia.github.io/ncx-infra-controller-rest/ |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~6-~6: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...se-Identifier: Apache-2.0 --> # NVIDIA Bare Metal REST OpenAPI Schema This repo contains...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~8-~8: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...repo contains OpenAPI schema for NVIDIA Bare Metal REST endpoints. Redoc rendered latest v...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@openapi/README.md` around lines 6 - 8, The README title and first sentence
still use "NVIDIA Bare Metal REST OpenAPI Schema" while the repo URL uses
ncx-infra-controller-rest; update the title string ("NVIDIA Bare Metal REST
OpenAPI Schema") and the description sentence that mentions "OpenAPI schema for
NVIDIA Bare Metal REST endpoints" to the new naming (e.g., "NCX Infra Controller
OpenAPI Schema" and "OpenAPI schema for NCX Infra Controller REST endpoints") so
the text matches the repository URL and naming convention.
| The REST layer can be deployed in the datacenter with NCX Infra Controller Core, or deployed anywhere in Cloud and allow Site Agent to connect from the datacenter. Multiple NCX Infra Controller Cores running in different datacenters can also connect to NCX Infra Controller REST through respective Site Agents. | ||
|
|
||
| View latest OpenAPI schema on [Github pages](https://nvidia.github.io/bare-metal-manager-rest/). | ||
| View latest OpenAPI schema on [Github pages](https://nvidia.github.io/ncx-infra-controller-rest/). |
There was a problem hiding this comment.
Use the official “GitHub” capitalization.
Line 14 should use “GitHub pages” instead of “Github pages”.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~14-~14: The official name of this software platform is spelled with a capital “H”.
Context: ...Agents. View latest OpenAPI schema on [Github pages](https://nvidia.github.io/ncx-inf...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 14, Replace the incorrect capitalization "Github pages"
with the official "GitHub pages" in the README line that reads "View latest
OpenAPI schema on Github pages" so the sentence becomes "View latest OpenAPI
schema on GitHub pages"; update any identical occurrences of the string "Github
pages" in the README to "GitHub pages" to ensure consistent, correct branding.
|
|
||
| ```go | ||
| import "github.com/nvidia/bare-metal-manager-rest/rla/internal/psmapi" | ||
| import "github.com/nvidia/ncx-infra-controller-rest/rla/internal/psmapi" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check go.mod module declaration
echo "=== Checking go.mod module declaration ==="
fd -e mod -x cat {} | grep -A2 "^module"
# Search for any remaining old import paths in Go files
echo -e "\n=== Searching for old import paths in Go files ==="
rg -t go "github\.com/nvidia/bare-metal-manager-rest" -C2
# Check if new import path is used consistently
echo -e "\n=== Verifying new import paths ==="
rg -t go "github\.com/nvidia/ncx-infra-controller-rest" --statsRepository: NVIDIA/ncx-infra-controller-rest
Length of output: 50389
Module path in documentation example does not match go.mod or actual imports—fix inconsistency before merge.
The documentation shows github.com/nvidia/ncx-infra-controller-rest in the code example, but verification reveals:
go.modfiles (root and sub-modules) still declaremodule github.com/nvidia/bare-metal-manager-rest- All Go source files throughout the workflow, db, and common packages still import from
github.com/nvidia/bare-metal-manager-rest
Either revert the documentation example to the current module path or update all go.mod files and imports to match the new path. Builds will fail otherwise.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rla/README.md` at line 171, The README import example uses the wrong module
path "github.com/nvidia/ncx-infra-controller-rest"; update it to match the
project's actual module path declared in go.mod and used across sources
("github.com/nvidia/bare-metal-manager-rest") or alternatively change all go.mod
module declarations and every import to the new path; locate the inconsistent
string in the README (the import line referencing psmapi) and either replace
that import to "github.com/nvidia/bare-metal-manager-rest/..." to match existing
imports, or perform a repository-wide refactor updating go.mod files and all
import statements to the new module path so builds and imports are consistent.
|
@Coco-Ben Thanks for starting the rename process, there are some other items that need renaming, I'll use your branch to push the changes. |
2 participants
Description
Type of Change
Services Affected
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes