Skip to content

fix: sanitize OpenShell placeholders in telemetry#38

Draft
WilliamK112 wants to merge 1 commit into
NVIDIA:mainfrom
WilliamK112:codex/sanitize-hermes-placeholder-telemetry
Draft

fix: sanitize OpenShell placeholders in telemetry#38
WilliamK112 wants to merge 1 commit into
NVIDIA:mainfrom
WilliamK112:codex/sanitize-hermes-placeholder-telemetry

Conversation

@WilliamK112

Copy link
Copy Markdown

Summary

  • sanitize literal openshell:resolve:env:* strings before forwarding Hermes hook payloads to NeMo Relay
  • preserve the hook payload structure while replacing placeholder-shaped strings with a non-resolvable sentinel
  • add a focused unit test for the forwarding path

Closes #23.

Validation

  • python -m py_compile examples/personal-community-sentiment-triage/agents/hermes/plugins/nemo-relay/__init__.py examples/personal-community-sentiment-triage/agents/hermes/plugins/nemo-relay/test_nemo_relay_plugin.py
  • python -m pytest examples/personal-community-sentiment-triage/agents/hermes/plugins/nemo-relay/test_nemo_relay_plugin.py -q
  • python scripts/check_license_headers.py --check examples/personal-community-sentiment-triage/agents/hermes/plugins/nemo-relay/__init__.py examples/personal-community-sentiment-triage/agents/hermes/plugins/nemo-relay/test_nemo_relay_plugin.py
  • git diff --check

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phoenix span is missing when telemetry contains OpenShell env placeholder

1 participant