Skip to content

Feat/cherry pick to 16#251

Closed
ayuskauskas wants to merge 6 commits into
mainfrom
feat/cherry-pick-to-16
Closed

Feat/cherry pick to 16#251
ayuskauskas wants to merge 6 commits into
mainfrom
feat/cherry-pick-to-16

Conversation

@ayuskauskas
Copy link
Copy Markdown
Collaborator

Description

git cherry-pick 046fe2e 4b3caae

Checklist

  • I am familiar with the Contributing Guidelines.
  • My commits are signed off (git commit -s) per the DCO.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

lockwobr and others added 6 commits May 19, 2026 13:07
* ci: publish keyless release attestations



* ci: drop nvcr release attestations



* ci: narrow release attestation identity



* ci: gate attestations to release tags



* docs: show immutable release subjects



* ci: attest helm chart releases



---------

Signed-off-by: AnouarMohamed <m.anouar@mundiapolis.ma>
Co-authored-by: Anouar Mohamed <m.anouar@mundiapolis.ma>
Updates chart/values.yaml to pin the multi-arch manifest digests for the
newly released operator (v0.16.0) and agent (v6.4.2) images, bumps
chart/Chart.yaml version and appVersion to v0.16.0 to match, and
regenerates chart/CHANGELOG.md via `make changelog COMPONENT=chart`. The
new chart/v0.16.0 section calls out the bundled component versions and
links to their GitHub releases.

Signed-off-by: Alex Yuskauskas <ayuskauskas@nvidia.com>
chore(chart): bump to v0.16.0 with pinned operator and agent digests
`helm push` (3.16+) writes the human-readable "Pushed:" and "Digest:"
lines to stderr, so the existing `$(helm push ...)` only captured an
empty stdout and the awk that extracts the digest produced no match.
Redirect stderr into stdout for the command substitution so the
digest-parser sees the same output that's already visible in the
runner log. The follow-up `sha256:[a-f0-9]{64}` regex check still
guards against malformed input.

Surfaced when publishing chart/v0.16.0 to oci://ghcr.io/nvidia/nodewright/charts:
the push itself succeeded, but the subsequent attestation steps failed
because no digest was extracted.

Signed-off-by: Alex Yuskauskas <ayuskauskas@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: af33ed28-818d-453a-bb85-feb5e6dc7069

📥 Commits

Reviewing files that changed from the base of the PR and between 6a75900 and 3844047.

📒 Files selected for processing (22)
  • .claude/CLAUDE.md
  • .github/actions/cosign-sign-sbom/action.yml
  • .github/actions/cosign-verify-release/action.yml
  • .github/actions/resolve-oci-digest/action.yml
  • .github/workflows/agent-ci.yaml
  • .github/workflows/lint-ci.yaml
  • .github/workflows/operator-ci.yaml
  • .github/workflows/release.yml
  • README.md
  • chart/CHANGELOG.md
  • chart/Chart.yaml
  • chart/README.md
  • chart/templates/_helpers.tpl
  • chart/values.yaml
  • docs/release-process.md
  • k8s-tests/chainsaw/helm/helm-chart-test/assert-no-schedule.yaml
  • k8s-tests/chainsaw/helm/helm-chart-test/assert-scheduled.yaml
  • k8s-tests/chainsaw/helm/helm-node-affinity-test/assert-no-schedule.yaml
  • k8s-tests/chainsaw/helm/helm-node-affinity-test/assert-scheduled.yaml
  • k8s-tests/chainsaw/helm/helm-scale-test/assert-override-resources.yaml
  • k8s-tests/chainsaw/helm/helm-scale-test/assert-scaled-resources.yaml
  • k8s-tests/chainsaw/helm/helm-webhook-test/assert-scheduled.yaml

📝 Walkthrough

Walkthrough

This PR coordinates the NodeWright v0.16.0 release, introducing artifact signing and attestation via three new GitHub composite actions (resolve-oci-digest, cosign-sign-sbom, cosign-verify-release) integrated into the agent, operator, and release CI workflows. It migrates software distribution to OCI-only (ghcr.io), bumps the Helm chart to v0.16.0 with new image registries, refactors the lychee link-checking workflow, updates the release process documentation with branch strategy and signature verification steps, and rebrand all Kubernetes test assertions to NodeWright. Configuration, documentation, and developer guidance are updated throughout to reflect the Skyhook-to-NodeWright transition.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

  • NVIDIA/nodewright#247: Updates Helm chart versioning and image references for the same v0.16.0 release cycle (overlapping chart/Chart.yaml and chart/values.yaml changes).
  • NVIDIA/nodewright#250: Addresses the agent container image repository path migration from Skyhook to NodeWright, which aligns with this PR's chart/values.yaml agent image updates.
  • NVIDIA/nodewright#244: Shares the same composite actions (cosign-sign-sbom, cosign-verify-release, resolve-oci-digest) and CI workflow integration logic for agent-ci, operator-ci, and release.yml.

Suggested reviewers

  • mskalka
  • rice-riley
  • lockwobr
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/cherry-pick-to-16

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Trivy (0.69.3)

Trivy execution failed: 2026-05-22T21:45:10Z FATAL Fatal error run error: fs scan error: scan error: scan failed: failed analysis: post analysis error: post analysis error: cloudformation scan error: fs filter error: fs filter error: walk error range error: stat smartylint.json: no such file or directory: range error: stat smartylint.json: no such file or directory


Comment @coderabbitai help to get the list of available commands and usage tips.

@lockwobr lockwobr deleted the feat/cherry-pick-to-16 branch May 22, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants