Skip to content

Use universally cluster-local FQDNs for temporal-setup container #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spidercensus wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −8
Open

Use universally cluster-local FQDNs for temporal-setup container #12

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de0ba2e
Use universally acceptable cluster-local FQDNs for temporal-setup con…
spidercensus May 29, 2026
3ce0a1b
fix the other urls
spidercensus May 29, 2026
966a705
apparently the same
spidercensus May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions deploy/helm/templates/temporal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,12 @@ spec:
- -c
- |
set -e
TEMPORAL_ADDR="{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
TEMPORAL_ADDR="{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
MAX_RETRIES=30
RETRY_DELAY=5

echo "Waiting for temporal frontend..."
until nc -z {{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc {{ .Values.temporal.services.frontend.port }}; do
until nc -z {{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local {{ .Values.temporal.services.frontend.port }}; do
Comment thread
coderabbitai[bot] marked this conversation as resolved.
echo "waiting for {{ $temporalName }}-frontend-service..."
sleep 2
done
Expand Down Expand Up @@ -375,7 +375,7 @@ spec:
value: {{ .Values.global.environment }}
{{- include "nv-config-manager.customLabelsEnv" . | nindent 8 }}
- name: TEMPORAL_ADDRESS
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
{{- if .Values.secrets.vault.configSecrets.enabled }}
- name: NV_CONFIG_MANAGER_CONFIG_SECRET_PATH
value: {{ include "nv-config-manager.vaultAgent.configSecretsFilePath" (dict "root" . "path" .Values.temporal.configManagerWorker.configSecrets.path) | quote }}
Expand Down Expand Up @@ -464,7 +464,7 @@ spec:
value: {{ .Values.global.environment }}
{{- include "nv-config-manager.customLabelsEnv" . | nindent 8 }}
- name: TEMPORAL_ADDRESS
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
ports:
- containerPort: 9000
name: http
Expand Down Expand Up @@ -579,7 +579,7 @@ spec:
- name: ENVIRONMENT
value: {{ .Values.global.environment }}
- name: TEMPORAL_ADDRESS
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
resources:
{{- toYaml .Values.temporal.scheduler.resources | nindent 10 }}
volumeMounts:
Expand Down Expand Up @@ -653,7 +653,7 @@ spec:
- name: TEMPORAL_API_HOST
value: {{ tpl .Values.temporal.gateway.api.hostname . | quote }}
- name: TEMPORAL_ADDRESS
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
volumeMounts:
{{- include "nv-config-manager.vaultAgent.configManagerIniVolumeMount" . | nindent 8 }}
{{- /* SPIFFE volume mount for outbound mTLS */ -}}
Expand Down Expand Up @@ -698,7 +698,7 @@ spec:
imagePullPolicy: {{ .Values.global.imagePullPolicy | default "IfNotPresent" }}
env:
- name: TEMPORAL_ADDRESS
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc:{{ .Values.temporal.services.frontend.port }}"
value: "{{ $temporalName }}-frontend-service.{{ .Values.global.namespace }}.svc.cluster.local:{{ .Values.temporal.services.frontend.port }}"
{{- $codecEndpoint := .Values.temporal.devUi.codecEndpoint }}
{{- if $codecEndpoint }}
- name: TEMPORAL_CODEC_ENDPOINT
Expand Down