Fix run_after names for stages with custom experiment naming - #19
Open
seshakolli wants to merge 1 commit into
Open
Fix run_after names for stages with custom experiment naming#19seshakolli wants to merge 1 commit into
seshakolli wants to merge 1 commit into
Conversation
Signed-off-by: seshukolli <seshudattakolli123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cross-stage
run_afterdependencies for stages whose submitted experimentnames differ from NVFlow's default
{expname}/{expname}-{env}convention.WorkflowRunnerpreviously inferred dependency experiment names directly fromstage configuration. That assumption does not hold for all stages:
{expname}-{env1}+{env2}+...validate_questionssubmits phase-specific experiments and downstream stagesneed to wait for the terminal
-phase2-llmexperimentThis change adds a stage-level
submitted_expnames()contract so dependencystages can report the experiment names that downstream stages should use as
run_after.Changes
BaseStage.submitted_expnames()with backward-compatible default namingWorkflowRunnerquery dependency stages for submitted experiment namesvalidate_questionsTesting
mainruff checkpassedruff format --checkpassedmypypassed on changed production filesgit diff --checkpassedThe remaining full-suite failures observed locally are the same Windows-specific
failures present on
main.