Use memfd when running ldconfig #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
This change copies ldconfig into a memfd before executing it from the createContainer hook. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
seal-ldconfig
branch
from
d6a6e7a to
5bdf14b
Compare
cdesiniotis
approved these changes
Feb 28, 2025
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jun 11, 2025
NVIDIA Container Toolkit 1.17.5 requires Go >= 1.22 [1], and starts
using enable-cuda-compat hooks in the Container Device Interface
specification generated by it [2]. For example:
"hookName": "createContainer",
"path": "/usr/bin/nvidia-cdi-hook",
"args": [
"nvidia-cdi-hook",
"enable-cuda-compat",
"--host-driver-version=570.153.02"
]
The new hook makes it possible to have containers with a
/usr/local/cuda/compat/libcuda.so.* that's newer than the proprietary
NVIDIA driver on the host operating system, so that applications can use
a newer CUDA without having to update the driver [3]. Even though this
sounds useful, the hook has been disabled until it's handled by the
'init-container' command and there's a clear way to test it.
The src/go.sum file was updated with 'go mod tidy'.
[1] NVIDIA Container Toolkit commit 5bdf14b1e7c24763
NVIDIA/nvidia-container-toolkit@5bdf14b1e7c24763
NVIDIA/nvidia-container-toolkit#941
NVIDIA/nvidia-container-toolkit#950
[2] NVIDIA Container Toolkit commit 76040ff2ad63fb82
NVIDIA/nvidia-container-toolkit@76040ff2ad63fb82
NVIDIA/nvidia-container-toolkit#906
NVIDIA/nvidia-container-toolkit#948
[3] https://docs.nvidia.com/deploy/cuda-compatibility/
containers#1662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies ldconfig into a memfd before executing it from the createContainer hook.
See NVIDIA/libnvidia-container@ff83efb where this was done for libnvidia-container.
This backports #941