Add option in toolkit container to enable CDI in runtime #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an EnableCDI method to the container engine config files and Updates the 'nvidia-ctk runtime configure' command to use this new method. Signed-off-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Christopher Desiniotis <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
This change also enables CDI in the configured runtime when the toolkit is installed with CDI enabled. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
backport-enable-cdi-container
branch
from
a1e4b50 to
eb48d2d
Compare
ArangoGutierrez
approved these changes
Mar 2, 2025
cdesiniotis
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add an option to enable CDI in container engines (containerd, crio, docker) from the toolkit contaienr.
This can be triggered through the
--enable-cdi-in-runtimecommand line option orRUNTIME_ENABLE_CDIenvironment variable.Backports #838