Added in-process wrapper restart latency #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namitdhameja
requested review from
apaithankar,
hexinw-nvidia,
rhewett-nv and
srogawski-nvidia
namitdhameja
requested review from
sbak5
and removed request for
srogawski-nvidia
rhewett-nv
reviewed
Jul 30, 2025
| str(exception_recvd_time), | ||
| ) | ||
| # Barrier to ensure all ranks have set their trigger time | ||
| store.completion_barrier( |
There was a problem hiding this comment.
The barriers defined in Store can only be used once. To add a barrier here we'll need to add another to the StoreMixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks min/max restart latency of the in-process wrapper