Add explicit async_fn_kwargs. #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aartibasant
reviewed
Oct 21, 2025
| return AsyncRequest(save_fn, save_args, [finalize_fn]) | ||
| return AsyncRequest(save_fn, save_args, [finalize_fn], async_fn_kwargs={}) | ||
|
|
||
| assert not is_async |
There was a problem hiding this comment.
Can you check if this path does not trigger the error: https://github.com/NVIDIA/nvidia-resiliency-ext/blob/main/src/nvidia_resiliency_ext/checkpointing/async_ckpt/torch_ckpt.py#L51
There was a problem hiding this comment.
kwargs inside the function def async_save(self, state_dict, *args, **kwargs): should be {} if nothing is passed to async_save so I don't think this should cause any error.
aartibasant
approved these changes
Oct 23, 2025
hexinw-nvidia
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue seen in tests:
Async save ckpt see TypeError: 'NoneType' object is not iterable with 0.5.0rc6