Skip to content

Allowed ft_launcher to run with default FaultToleranceConfig #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

Allowed ft_launcher to run with default FaultToleranceConfig #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba3bf1d
Allowed ft_launcher to run with default FaultToleranceConfig
hexinw-nvidia Oct 21, 2025
4d1d010
Merge branch 'main' into regression
hexinw-nvidia Oct 22, 2025
6e67e93
Merge branch 'main' into regression
hexinw-nvidia Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/nvidia_resiliency_ext/fault_tolerance/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ def from_args(args: argparse.Namespace):
ft_cfg._fix_log_level_type()
ft_cfg._fix_rank_termination_signal_type()

# If we didn't read from file and no CLI args were provided, raise an error
if not (is_read_from_file or cli_ft_args):
raise ValueError("No fault tolerance configuration provided.")

return ft_cfg

def to_yaml_file(self, cfg_path: str) -> None:
Expand Down