Skip to content

server: release the session lock when a client disconnects mid-stream #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jethac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

server: release the session lock when a client disconnects mid-stream #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions moshi/moshi/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@ async def opus_loop():
return
await asyncio.sleep(0.001)
pcm = opus_reader.read_pcm()
if pcm is None:
# client opus stream ended (disconnect mid-stream);
# exit cleanly so the session lock is released.
return
if pcm.shape[-1] == 0:
continue
if all_pcm_data is None:
Expand Down