Crash post_processing script update#1464
Open
dakhare-creator wants to merge 3 commits intoNVIDIA:mainfrom
Open
Crash post_processing script update#1464dakhare-creator wants to merge 3 commits intoNVIDIA:mainfrom
dakhare-creator wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
update main
update main
Contributor
Greptile SummaryThis PR enhances crash simulation post-processing to support computing MSE (position, velocity, acceleration) across multiple test samples. The changes include refactored Python script to handle both single-sample and multi-sample analysis, a new Jupyter notebook for comparing L2 errors across runs, and an updated shell script. Major Changes:
Critical Issues:
Important Files Changed
Last reviewed commit: 3019254 |
|
|
||
| mkdir -p results | ||
|
|
||
| dir_path= /path/to/output/directory |
Contributor
There was a problem hiding this comment.
Space after = causes bash syntax error - variable won't be set
Suggested change
| dir_path= /path/to/output/directory | |
| dir_path=/path/to/output/directory |
| --output_path $dir_path/post_processing_results \ | ||
| # --save_csv | ||
| python compute_l2_error.py --predicted_parent $dir_path/predicted_vtps --exact_parent $dir_path/exact_vtps --output_plot $dir_path/post_processing_results/l2_error.png --output_csv $dir_path/post_processing_results/l2_error.csv | ||
| python plot_cross_section.py --pred_dir $pred_path --exact_dir $exact_path --output_file $dir_path/post_processing_results/cross_section.png |
Contributor
There was a problem hiding this comment.
$pred_path and $exact_path are undefined - this line will fail
Suggested change
| python plot_cross_section.py --pred_dir $pred_path --exact_dir $exact_path --output_file $dir_path/post_processing_results/cross_section.png | |
| python plot_cross_section.py --pred_dir $dir_path/predicted_vtps --exact_dir $dir_path/exact_vtps --output_file $dir_path/post_processing_results/cross_section.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.