Adds Marching Cubes algorithm to PhysicsNeMo-Mesh#1488
Open
peterdsharpe wants to merge 8 commits intoNVIDIA:mainfrom
Open
Adds Marching Cubes algorithm to PhysicsNeMo-Mesh#1488peterdsharpe wants to merge 8 commits intoNVIDIA:mainfrom
peterdsharpe wants to merge 8 commits intoNVIDIA:mainfrom
Conversation
… isosurface extraction from 3D scalar fields. Updates CHANGELOG to reflect new functionality. Includes tests for the marching cubes implementation, ensuring geometric accuracy and input validation.
Collaborator
Author
|
/blossom-ci |
Contributor
Greptile SummaryThis PR adds a
Important Files Changed
Last reviewed commit: e193fe0 |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…olation for non-uniform grid coordinates. Adds a new test case to validate the behavior with non-uniform coordinates, ensuring correct mesh generation and topology. Updates documentation for clarity on coordinate mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Allows mesh generation from SDF files using marching cubes. Part of softening the deprecation blow of #1487.
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.