Manually update versions.json to fix breaking changes in rapids-cmake#3582
Merged
ttnghia merged 3 commits intoNVIDIA:branch-25.10from Jul 30, 2025
Merged
Manually update versions.json to fix breaking changes in rapids-cmake#3582ttnghia merged 3 commits intoNVIDIA:branch-25.10from
versions.json to fix breaking changes in rapids-cmake#3582ttnghia merged 3 commits intoNVIDIA:branch-25.10from
Conversation
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses breaking changes in rapids-cmake by updating the dependency configuration to include required source_subdir keys for specific dependencies. The changes ensure cmake can complete successfully after breaking changes introduced in rapids-cmake PR #882.
- Updated
versions.jsonto addsource_subdirfield for kvikio and zstd dependencies - Updated the rapids-cmake SHA to reference the version containing the breaking changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| thirdparty/cudf-pins/versions.json | Added required source_subdir fields for kvikio ("cpp") and zstd ("build/cmake") dependencies |
| thirdparty/cudf-pins/rapids-cmake.sha | Updated SHA to point to the new rapids-cmake version with breaking changes |
This reverts commit e9e6260.
Collaborator
Author
|
build |
abellina
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are breaking changes in
rapids-cmakedue to rapidsai/rapids-cmake#882, which requires a JSON key-valuesource_subdirfor some dependencies. Without it, cmake will not be able to complete.This PR fixes that issue, adding
source_subdirto the problematic dependencies.