[auto-merge] bot-auto-merge-release/26.04 to main [skip ci] [bot]#4423
[auto-merge] bot-auto-merge-release/26.04 to main [skip ci] [bot]#4423
Conversation
This commit introduces utility iterators to be used in place `cudf::detail` iterators. This is to further reduce dependencies on `cudf::detail` APIs that are now deemed private to the CUDF project. ### `make_counting_transform_iterator` This change introduces a version of `make_counting_transform_iterator` that is specific to Spark RAPIDS JNI. The previous version of this function is from `cudf::detail`, which is now deemed private to cuDF. This commit should allow Spark RAPIDS JNI to be insulated from changes to interfaces in `cudf::detail`. Note that this version does not use `thrust::transform_iterator`. It banks instead on `cuda::make_transform_iterator` instead. --------- Signed-off-by: MithunR <mithunr@nvidia.com>
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
|
SUCCESS - auto-merge |
Greptile SummaryThis auto-merge PR brings the Key changes:
Confidence Score: 5/5Safe to merge — all changes are consistent mechanical migrations with no logic alterations and well-scoped dependency bumps The PR is a clean release-to-main auto-merge. The core change (replacing cudf's internal iterator API with a local CCCL-backed wrapper) is applied uniformly across all call sites and all start values remain integer literals that satisfy the new static_assert constraint. The cudf::util:: namespace qualification in row_conversion.cu corrects what was likely a previously-implicit resolution. No logic is altered anywhere. Dependency bumps are tracked with explicit SHAs. No P0 or P1 issues found. No files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["cudf::detail::make_counting_transform_iterator\n(thrust::counting_iterator — internal API)"]
B["spark_rapids_jni::util::make_counting_transform_iterator\n(cuda::counting_iterator — CCCL public API)"]
subgraph Callers["Migrated callers"]
C[from_json_to_structs.cu]
D[get_json_object.cu]
E[hyper_log_log_plus_plus.cu]
F[hyper_log_log_plus_plus_host_udf.cu]
G[row_conversion.cu]
H[shuffle_assemble.cu]
I[shuffle_split.cu]
J[tests/row_conversion.cpp]
K[tests/shuffle_split.cu]
L[tests/hyper_log_log_plus_plus.cu]
end
A -->|replaced by| B
Callers -->|use| B
subgraph Deps["Updated dependencies"]
M[thirdparty/cudf submodule]
N[rmm 26.06]
O[kvikio 26.06]
P[CCCL 3.3.0]
end
B -->|backed by| P
Reviews (1): Last reviewed commit: "Auto-merge use main versions" | Re-trigger Greptile |
auto-merge triggered by github actions on
bot-auto-merge-release/26.04to create a PR keepingmainup-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.