Skip to content

Compatibility fixes for cuml 25.02.1 patch #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

Compatibility fixes for cuml 25.02.1 patch #863

merged 3 commits into from
Mar 6, 2025

Conversation

rishic3
Copy link
Collaborator

@rishic3 rishic3 commented Mar 6, 2025 •
edited
Loading

Relevant PRs: cuml 6235, cuml 6142, for sklearn compatibility.

  • n_init defaults to "warn" as a future warning for the user (still ends up defaulting to 1), since the default will change to "auto" in 25.04 to match sklearn.
  • LR output shape changed from (n_classes, n_rows) to (n_rows, n_classes) to match sklearn.

Resolves #860

@rishic3
Copy link
Collaborator Author

rishic3 commented Mar 6, 2025

build

@rishic3 rishic3 requested a review from lijinf2 March 6, 2025 19:37
@rishic3 rishic3 merged commit b28e77a into NVIDIA:branch-25.02 Mar 6, 2025
3 checks passed
@rishic3 rishic3 deleted the cuml-25.02.1-patch branch March 6, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijinf2 lijinf2 lijinf2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishic3 @lijinf2