Support CrossValidator on connect plugin #907
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <[email protected]>
eordentlich
reviewed
May 7, 2025
| } | ||
|
|
||
| // MLOperator represents the ML operators like (Estimator, Transformer or Evaluator) | ||
| message MlOperator { |
There was a problem hiding this comment.
Will this be pulled in from Spark?
| import java.util.Optional | ||
| import scala.jdk.CollectionConverters.SeqHasAsJava | ||
|
|
||
| class RapidsRelationPlugin extends RelationPlugin { |
There was a problem hiding this comment.
Does this need to be registered with spark connect via a spark conf? Would be helpful to add usage info?
| # Building the Python build and building the mypy interfaces. | ||
| - plugin: buf.build/protocolbuffers/python:v28.3 | ||
| out: ../../../python/src/spark_rapids_ml/proto | ||
| - plugin: buf.build/grpc/python:v1.67.0 |
There was a problem hiding this comment.
Do these versions (v28.3 and v1.67.0) need to match exactly the java side in the pom.xml file ?
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| version: v1 |
There was a problem hiding this comment.
How is this version used and does it have to align with the jvm side?
There was a problem hiding this comment.
What runs this script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.