Fix compile break from BloomFilter.create deprecation#14468
Merged
mythrocks merged 1 commit intoNVIDIA:mainfrom Mar 25, 2026
Merged
Fix compile break from BloomFilter.create deprecation#14468mythrocks merged 1 commit intoNVIDIA:mainfrom
mythrocks merged 1 commit intoNVIDIA:mainfrom
Conversation
Fixes NVIDIA#14462. This change addresses the build breakage in `spark-rapids` from the deprecation of `spark-rapids-jni` `BloomFilter.create(int,int)` deprecation, introduced in NVIDIA/spark-rapids-jni#4360. This is a stop-gap solution that only restores prior behaviour, i.e. support for the BloomFilter v1 binary format. Actual support for the BloomFilter v2 format will follow in NVIDIA#14406. Signed-off-by: MithunR <mithunr@nvidia.com>
Contributor
Greptile SummaryThis PR is a minimal stop-gap fix that resolves a compile break introduced when
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Spark as Spark Aggregate Exec
participant Update as GpuBloomFilterUpdate
participant JNI as spark-rapids-jni BloomFilter
participant Merge as GpuBloomFilterMerge
Spark->>Update: reductionAggregate(col: ColumnVector)
Update->>JNI: BloomFilter.create(VERSION_1, numHashes, numBits, DEFAULT_SEED)
JNI-->>Update: bloomFilter (Scalar)
Update->>JNI: BloomFilter.put(bloomFilter, col)
JNI-->>Update: updated bloomFilter
Update-->>Spark: bloomFilter Scalar (binary)
Spark->>Merge: reductionAggregate(col: ColumnVector)
alt all nulls
Merge-->>Spark: Scalar.listFromNull(UINT8)
else some nulls
Merge->>Merge: filter nulls via Table
Merge->>JNI: BloomFilter.merge(filtered column)
JNI-->>Merge: merged bloomFilter
Merge-->>Spark: merged bloomFilter
else no nulls
Merge->>JNI: BloomFilter.merge(col)
JNI-->>Merge: merged bloomFilter
Merge-->>Spark: merged bloomFilter
end
Reviews (2): Last reviewed commit: "Fix compile break from BloomFilter.creat..." | Re-trigger Greptile |
abellina
approved these changes
Mar 25, 2026
Collaborator
|
build |
3 tasks
jihoonson
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14462.
Description
This change addresses the build breakage in
spark-rapidsfrom the deprecation ofspark-rapids-jniBloomFilter.create(int,int)deprecation, introduced in NVIDIA/spark-rapids-jni#4360.This is a stop-gap solution that only restores prior behaviour, i.e. support for the BloomFilter v1 binary format.
Actual support for the BloomFilter v2 format will follow in #14406.
Checklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)