feat: add vLLM GB200 GSM8K repro configs#106
Draft
alec-flowers wants to merge 2 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reproducible vLLM DeepSeek-V4-Pro GB200 GSM8K eval path and the two exact 1P1D configs used for the SA smoke comparison.
benchmark.type: lm-evalrunner that evaluates OpenAI-compatible chat endpoints with EleutherAIlm-eval.disagg-gb200-1p1d-dep8-tp8-gsm8k-smoke.yamldisagg-gb200-1p1d-dep8-dep8-gsm8k-smoke.yamlSA Validation
Successful runs on the SA GB200 cluster:
15558exact_match,strict-match:0.8635exact_match,flexible-extract:0.859715559exact_match,strict-match:0.9636087945413192exact_match,flexible-extract:0.9628506444275967Both use full GSM8K test split (
1319examples),5shots from the task YAML,EVAL_CONC=128,max_length=9472, andmax_tokens=5376.Test Plan
PYTHONPATH=src /home/aflowers/Documents/agent/srt-slurm-gsm8k-worktree/.venv/bin/python -m pytest tests/ -q639 passed, 2 skipped, 6 deselected/home/aflowers/Documents/agent/srt-slurm-gsm8k-worktree/.venv/bin/ruff check src/srtctl tests/test_benchmarks.pyload_config; both resolve asbenchmark=lm-eval, served modeldeepseek-ai/DeepSeek-V4-Pro,EVAL_CONC=128.Note: a fresh
uv run pytest ...in the new worktree could not resolvejinja2from the configured package index, so validation used the existing populated srt-slurm dev venv withPYTHONPATH=srcpinned to this worktree.Preflight Note
This PR also keeps
srtctl applyfrom running blocking preflight implicitly. Some GB200 clusters keep model paths on per-compute-node local storage, so login-node preflight can fail even though the job would run correctly once scheduled. Explicit validation remains available viasrtctl preflight -f ....