Skip to content

Qualify nsys report names for MPI workers#142

Open
nv-roverman wants to merge 1 commit into
NVIDIA:sa-submission-q2-2026from
nv-roverman:roverman/q2-nsys-mpi-report-names
Open

Qualify nsys report names for MPI workers#142
nv-roverman wants to merge 1 commit into
NVIDIA:sa-submission-q2-2026from
nv-roverman:roverman/q2-nsys-mpi-report-names

Conversation

@nv-roverman
Copy link
Copy Markdown

Summary

  • Add rank-qualified nsys output paths for MPI-style endpoint launches.
  • Document Slurm rank expansion in generated nsys report names.
  • Avoid multiple MPI ranks writing the same .nsys-rep file.

Testing

  • uv run pytest tests/test_profiling.py

Signed-off-by: Robert Overman <roverman@nvidia.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (sa-submission-q2-2026@fdb1be7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/srtctl/cli/mixins/worker_stage.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             sa-submission-q2-2026     #142   +/-   ##
========================================================
  Coverage                         ?   61.00%           
========================================================
  Files                            ?       48           
  Lines                            ?     4147           
  Branches                         ?        0           
========================================================
  Hits                             ?     2530           
  Misses                           ?     1617           
  Partials                         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants