Skip to content

Assign Dynamo system ports by launch role#143

Open
nv-roverman wants to merge 1 commit into
NVIDIA:sa-submission-q2-2026from
nv-roverman:roverman/q2-dynamo-system-port-per-rank
Open

Assign Dynamo system ports by launch role#143
nv-roverman wants to merge 1 commit into
NVIDIA:sa-submission-q2-2026from
nv-roverman:roverman/q2-dynamo-system-port-per-rank

Conversation

@nv-roverman
Copy link
Copy Markdown

Summary

  • Assign explicit Dynamo system ports to frontend processes.
  • Reserve backend system-port ranges based on gpus_per_node.
  • Derive MPI worker DYN_SYSTEM_PORT from the assigned base plus SLURM_LOCALID.

Testing

  • uv run pytest tests/test_frontend_topology.py tests/test_endpoint_allocation.py

Signed-off-by: Robert Overman <roverman@nvidia.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (sa-submission-q2-2026@fdb1be7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/srtctl/cli/mixins/worker_stage.py 11.11% 8 Missing ⚠️
src/srtctl/backends/trtllm.py 0.00% 1 Missing ⚠️
src/srtctl/backends/vllm.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             sa-submission-q2-2026     #143   +/-   ##
========================================================
  Coverage                         ?   61.04%           
========================================================
  Files                            ?       48           
  Lines                            ?     4161           
  Branches                         ?        0           
========================================================
  Hits                             ?     2540           
  Misses                           ?     1621           
  Partials                         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants