Accept remote telemetry container aliases in preflight#202
Open
fallintoplace wants to merge 1 commit into
Open
Accept remote telemetry container aliases in preflight#202fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srtslurm.yaml containersto resolve to remote imagesnvcr.ioimageWhy
Telemetry container fields are resolved through the same
containersmap as model containers, but telemetry preflight always checked the resolved value as a local file. That rejected remote image aliases even though they are still container images that can be pulled by the runtime container support.Test plan
PYTHONPATH=src uv run --no-project --with pytest --with pyyaml --with jinja2 --with marshmallow --with marshmallow-dataclass --with requests --with rich --with questionary --with ruamel.yaml --with pydantic --with mcp --with matplotlib -- python -m pytest tests/test_validation.py -vuv run --no-project --with ruff -- ruff check src/srtctl/core/validation.py tests/test_validation.py