[codex] Port HF cache cleanup#49
Merged
ishandhanani merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the HF cache cleanup and single-node model pre-download work from
ishandhanani/srt-slurmPR #251 intoNVIDIA/srt-slurm.This adds pre-worker HuggingFace cache handling in
SweepOrchestrator:HF_*andHUGGING_FACE_*env vars from backend mode environments.lockfiles from sharedHF_HOMEWhy
HF-backed runs can start multiple workers that all try to populate the same shared model cache at once. That can leave stale locks or trigger lock contention. Pre-caching the model once before worker startup avoids the fan-out download race.
Validation
uv run --with ruff ruff check src/srtctl tests/test_hf_cache.pyuv run --with pytest pytest tests/test_hf_cache.py tests/test_configs.py::TestHuggingFaceModelSupport tests/test_benchmarks.py -q