Skip to content

[codex] Keep MCP validation off host cluster config#56

Merged
ishandhanani merged 1 commit intomainfrom
codex/mcp-compute-side-validation
Apr 21, 2026
Merged

[codex] Keep MCP validation off host cluster config#56
ishandhanani merged 1 commit intomainfrom
codex/mcp-compute-side-validation

Conversation

@ishandhanani
Copy link
Copy Markdown
Collaborator

@ishandhanani ishandhanani commented Apr 21, 2026

Summary

  • make srtctl MCP reject host-side cluster defaults
  • stop MCP preflight from implicitly loading host-side srtslurm.yaml
  • clarify MCP responses and docs that cluster defaults, aliases, paths, containers, filesystem checks, and dry-run behavior must run compute-side
  • keep structural topology validation in MCP schema validation

Validation

  • uv run pytest tests/test_mcp_spec.py tests/test_validation.py -q

@ishandhanani ishandhanani marked this pull request as ready for review April 21, 2026 22:25
@ishandhanani ishandhanani merged commit 3b316d1 into main Apr 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@nlevin-ui nlevin-ui Awaiting requested review from nlevin-ui nlevin-ui is a code owner

@csahithi csahithi Awaiting requested review from csahithi csahithi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ishandhanani