feat(profiling): add extra_nsys_args for optional nsys CLI flags#59
Open
zhengd-nv wants to merge 3 commits intoNVIDIA:mainfrom
Open
feat(profiling): add extra_nsys_args for optional nsys CLI flags#59zhengd-nv wants to merge 3 commits intoNVIDIA:mainfrom
zhengd-nv wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage ? 70.52%
=======================================
Files ? 60
Lines ? 6325
Branches ? 0
=======================================
Hits ? 4461
Misses ? 1864
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
YAMY1234
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Summary
Adds an optional
profiling.extra_nsys_argsfield (list[str] | null) so users can append extra arguments to thensys profilewrapper for both the default (SGLang) and TRTLLM worker command prefixes, without changing the fixed baseline flags.Behavior
-o <output>so output path and downstream behavior stay predictable.typeisnsysornsys-time(sameget_nsys_prefix/_get_nsys_prefix_trtllmpaths as existing nsys support).extra_nsys_argswith the same ordering relative to-o.--trace-fork-before-exec=trueinsertion forfrontend_type="dynamo"remains unchanged relative to-o.Configuration
YAML example:
Documented in
docs/profiling.mdanddocs/config-reference.md.Tests
tests/test_profiling.py: asserts extra args appear in the prefix and before-ofor the default path and forbackend_type="trtllm".