refactor(gpqa): drop structured runner; ship configs/gpqa/run.sh#96
Open
ishandhanani wants to merge 1 commit intomainfrom
Open
refactor(gpqa): drop structured runner; ship configs/gpqa/run.sh#96ishandhanani wants to merge 1 commit intomainfrom
ishandhanani wants to merge 1 commit intomainfrom
Conversation
Ports GPQA to the same `configs/<bench>/` script-based pattern that AIME moved to in PR #91, per follow-up issue #92. Same nemo-run unquoting hazard motivates the move: any benchmark passing Hydra `++overrides` through `ns eval` is one backslash-bearing extract_regex away from silently-broken evaluation. Replaces `src/srtctl/benchmarks/gpqa.py` (sglang.test.run_eval-based) with a NeMo-Skills-driven `configs/gpqa/run.sh` that recipes wire up via `type: custom`. Defaults match the upstream reasoning-eval reference (--benchmarks=gpqa:32, max_tokens=400000, temperature=1.0); all knobs overridable via env. Script warns at startup if HF_TOKEN is unset since GPQA Diamond is HF-gated. Removed: - `src/srtctl/benchmarks/gpqa.py` (62 LOC) - `src/srtctl/benchmarks/scripts/gpqa/bench.sh` (53 LOC) - `BenchmarkType.GPQA` enum - `gpqa` registry assertion in `tests/test_benchmarks.py` - GPQA row + section in `docs/config-reference.md` - `gpqa` mention in `examples/example.yaml` and `docs/architecture.md` tree Updated: - `docs/accuracy.md` GPQA section → script-based runbook (recipe shape, HF gating note, reasoning-mode env vars pointer back to AIME) - `src/srtctl/benchmarks/__init__.py` — drop gpqa import + __all__ entry - 6 existing `type: "gpqa"` recipes migrated 1:1 to `type: custom` + `bash /configs/gpqa/run.sh`, preserving their MAX_TOKENS / REPEAT / NUM_THREADS as env-var overrides - 2 h200 recipes' commented-out `type: "gpqa"` block replaced with a one-line pointer to the new docs Backward compat: none. Recipes with `type: gpqa` will fail schema validation — migration is a 1:1 swap to the `type: custom` block above. Test plan: `make check` — 611 passed, 2 skipped (matches pre-change baseline). MMLU / longbenchv2 / gsm8k untouched per the issue's focused-PR-per-benchmark plan. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports GPQA to the
configs/<bench>/script-based pattern that AIME moved to in #91. Closes step 1 of follow-up issue #92.Same nemo-run unquoting hazard motivates the move: any benchmark passing Hydra
++overridesthroughns evalis one backslash-bearingextract_regexaway from silently-broken evaluation. Script-based path is immune.What ships
Removed
src/srtctl/benchmarks/gpqa.py(62 LOC, sglang.test.run_eval-based runner)src/srtctl/benchmarks/scripts/gpqa/bench.sh(53 LOC)BenchmarkType.GPQAenumgpqaregistry assertion intests/test_benchmarks.pydocs/config-reference.mdgpqamention inexamples/example.yamlanddocs/architecture.mdtreeAdded
configs/gpqa/run.sh— orchestratesns prepare_data gpqa+ns eval --benchmarks=gpqa:\$REPEATagainstlocalhost:8000/v1(the in-job dynamo frontend). Tuning knobs (MAX_TOKENS,REPEAT,NUM_THREADS,TEMPERATURE,TOP_P,SEED,DATASET,MODEL) env-var overridable; defaults match the upstream reasoning-eval reference (max_tokens=400000,repeat=32,temperature=1.0,num_threads=512). Warns at startup ifHF_TOKENis unset (GPQA Diamond is HF-gated).Updated
docs/accuracy.mdGPQA section → script-based runbook with HF gating note + pointer back to AIME's reasoning-mode env varssrc/srtctl/benchmarks/__init__.py— drop gpqa import +__all__entrytype: "gpqa"recipes migrated 1:1 totype: custom+bash /configs/gpqa/run.sh, preserving theirMAX_TOKENS/REPEAT/NUM_THREADSas env-var overridestype: "gpqa"block replaced with a one-line pointer to the new docsRecipe shape (from new docs section)
Backward compatibility
None. Recipes with
type: gpqawill fail schema validation. Migration is 1:1 to the block above. The 6 in-tree GPQA recipes are migrated in this PR.Test plan
Follow-up
MMLU / longbenchv2 / gsm8k still to come per #92 — separate focused PRs in the order the issue lays out.
🤖 Generated with Claude Code