Skip to content

Fix custom capture keybind #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

skurtyyskirts
Copy link
Contributor

Fixes bug where rtx.captureHotKey wasn't allowing custom keys to capture. set bool bFoundValidConfig = true

@NV-LL
Copy link

NV-LL commented Mar 13, 2025

REMIX-4005 for internal tracking

@MarkEHenderson
Copy link
Collaborator

Please remember to squash your commits, and to add yourself to the Github Contributors section in src\dxvk\imgui\dxvk_imgui_about.cpp

Copy link
Contributor Author

@skurtyyskirts skurtyyskirts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe everything's set, please let me know if I need to do anything further

@MarkEHenderson
Copy link
Collaborator

Umm, you marked two comments as resolved without actually making any related changes. Did you forget to push?

Also, please remember to squash your commits.

@skurtyyskirts skurtyyskirts force-pushed the main branch 6 times, most recently from fbcc257 to 36aa58a Compare April 15, 2025 03:06
- Enables the rtx.showRaytracingOption for Half-Life 2.
- Fixes an issue where rtx.captureHotKey did not correctly parse
  multiple keys or certain custom key combinations.
- Adds contributor information.
@skurtyyskirts
Copy link
Contributor Author

Oops sorry about that, I thiiiiink I've got it now

@MarkEHenderson
Copy link
Collaborator

Well, now you've just deleted all the submodules and included a config change that triggers endless debate within the team... and entirely removed all the changes to the keybind system.

@skurtyyskirts
Copy link
Contributor Author

Oh mercy, this one's all over the place - I'll close it and reopen a new one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants