Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to CUDA dispatch macros and improvements to the
setup.py
script for the Kaolin library. The most important changes include updating the dispatch macros to usescalar_type()
and enhancing thesetup.py
script for better version handling and logging.CUDA dispatch macro updates:
AT_DISPATCH_FLOATING_TYPES_AND_HALF
macros to usescalar_type()
instead oftype()
inkaolin/csrc/ops/spc/point_utils_cuda.cu
(interpolate_trilinear_cuda_impl
,coords_to_trilinear_cuda_impl
) [1] [2].AT_DISPATCH_FLOATING_TYPES_AND_HALF
macros to usescalar_type()
instead oftype()
inkaolin/csrc/ops/spc/query_cuda.cu
(query_cuda_impl
,query_multiscale_cuda_impl
,query_cuda_impl_empty
) [1] [2] [3].AT_DISPATCH_FLOATING_TYPES_AND_HALF
andAT_DISPATCH_INTEGRAL_TYPES
macros to usescalar_type()
inkaolin/csrc/render/spc/raytrace_cuda.cu
(mark_pack_boundaries_cuda_impl
,diff_cuda_impl
,sum_reduce_cuda_impl
,cumsum_cuda_impl
,cumprod_cuda_impl
) [1] [2] [3] [4] [5] [6] [7].Setup script improvements:
setup.py
to better handle version constraints and logging for PyTorch and Cython dependencies [1] [2].setup.py
[1] [2].