Update building class in tax lots for latest PLUTO; Prefer Node 12 #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthesignals
force-pushed
the
998-update-lookups-build-class-tax-lots
branch
3 times, most recently
from
94b1451 to
3c8f0e4
Compare
allthesignals
commented
Oct 22, 2021
| const bldgclassLookup = { | ||
| A0: 'One Family Dwellings - Cape Cod', | ||
| A1: 'One Family Dwellings - Two Stories Detached (Small or Moderate Size, With or Without Attic)', | ||
| A2: 'One Family Dwellings - One Story (Permanent Living Quarters)', |
Collaborator
Author
There was a problem hiding this comment.
Looks like some of this was pulled from an old markdown file:
allthesignals
force-pushed
the
998-update-lookups-build-class-tax-lots
branch
from
3c8f0e4 to
b4a461e
Compare
allthesignals
force-pushed
the
998-update-lookups-build-class-tax-lots
branch
from
5bad7d3 to
49e3f1d
Compare
Collaborator
Author
|
Ran this through a spell-checker lol. Didn't see any other typos. @godfreyyeung @TylerMatteo |
allthesignals
force-pushed
the
998-update-lookups-build-class-tax-lots
branch
from
1b21ebc to
49e3f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #998
Uses building class codes from here: https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/data/lookup_bldgclass.csv
I think the old descriptions were pulled from this old markdown file: https://github.com/NYCPlanning/data-engineering-doc/blob/1c1f656f68cda5f817d14a77054c1cd8a8411d57/products/pluto.md
So, there are some lower quality descriptions in the maintained version. I'll just fix a few of the typos and propose changes upstream...