Skip to content

Conversation

@pratishta
Copy link
Contributor

@pratishta pratishta commented Jun 5, 2025

Closes #1228

To replicate the bug / test out the PR:

  1. Open ZoLa / localhost:4200
  2. Switch to mobile view if on desktop
  3. Close the new features pop up
  4. Click on 'Edit Map Layers'
  5. Scroll down and exit the "Welcome to..." panel

Now you should not be able to scroll back up or down. This PR should fix that.*

  • The caveat is, the overflow property I removed was initially in place to fix a mobile scrolling issue. So it may be that there are some knock-on effects

@pratishta pratishta requested a review from a team as a code owner June 5, 2025 19:18
@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for labs-zola ready!

Name Link
🔨 Latest commit 59b2328
🔍 Latest deploy log https://app.netlify.com/projects/labs-zola/deploys/68558e7f90297400087cac15
😎 Deploy Preview https://deploy-preview-1260--labs-zola.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@TangoYankee
Copy link
Member

To replicate the bug / test out the PR:

  1. Open ZoLa / localhost:4200
  2. Switch to mobile view if on desktop

ZoLa is configured to automatically create deploy previews on Netlify; running it locally isn't strictly necessary to test the behavior.

There's apparently also a QR code so that it's easy to open on a mobile device.

@pratishta pratishta force-pushed the 1228/layer-palette-unreachable-on-mobile branch 2 times, most recently from f7ab1bc to b946f5c Compare June 20, 2025 15:36
Copy link
Contributor

@horatiorosa horatiorosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pratishta pratishta force-pushed the 1228/layer-palette-unreachable-on-mobile branch from cd9ed58 to 36c449e Compare June 20, 2025 16:17
Personal local development

Stop tracking vscode settings

Restore lock files

Remove yarn

Re-adding yarn.lock

Re-adding yarn.lock again
@pratishta pratishta force-pushed the 1228/layer-palette-unreachable-on-mobile branch from 36c449e to 59b2328 Compare June 20, 2025 16:38
@pratishta pratishta merged commit a23ee58 into develop Jun 20, 2025
5 of 7 checks passed
TylerMatteo added a commit that referenced this pull request Jun 25, 2025
#1267)

* Issue 1219 Updated Asset Link in ZOLA

* Issue 1222 Updated Web Link

* Digital ocean tax maps

Update digital tax map hyperlinks to point to digital ocean spaces

closes #1221

* Bugfix: incorrect zoning map path

Add leading zero to zoning map path

closes #1221

* Adds Zoning Map Index Sidebar

* Refactored to pull data from Carto.

* Moved inline styles to scss

* String manipulation of header text.

* Removed unneccessary file

* Issue 1229 Add Zoning Index Layer to ZOLA

* Issue 1242 Enabled Clickable Zoning Index Map Grid Squares
 - enabled select stying to be applied to clicked ZMI grids
 - enabled bookmarks with formatted titles

* Issue 1243 Add Zoning for Accessibility Layer
 - Closes #1243
 - Closes #1244
 - Closes #1245
 - Closes #1246
 - Closes #1247
 - Closes #1248

* Added Zoning Map Index to new features modal and features page.

* Issue 1258 Update ZFA Slide Out Description text

Closes #1258

* Add Zoning Map Index to Features section

* Change hideMessage local storage variable name so users see modal with new Zoning Map Index Feature

* Update intersecting layer template to hide ZFA layer behind feature flag

* Layer palette unreachable on mobile (#1260)

* Remove overflow property to enable scroll

* Add vscode settings to gitignore

Personal local development

Stop tracking vscode settings

Restore lock files

Remove yarn

Re-adding yarn.lock

Re-adding yarn.lock again

* Issue 1253 Add ZFA messaging to ZOLA
 - Add demo gif of ZFA functionality
 - Add ZFA callout messaging to popup and features tab
 - change local storage key to trigger pop-up with new ZFA messaging

* Update netlify.toml to set ZFA feature flag to ON (#1266)

---------

Co-authored-by: horatio <[email protected]>
Co-authored-by: tangoyankee <[email protected]>
Co-authored-by: David Hochbaum <[email protected]>
Co-authored-by: py <[email protected]>
Co-authored-by: horatio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layer palette unreachable on mobile

4 participants