Skip to content

Conversation

@dhochbaum-dcp
Copy link
Contributor

This PR updates nyc.gov/planning links.

Note: I did notice some inconsistencies between the new anchor links and the environment.js contents for some of the special purpose districts. Ex:

  • Special Planned Community Preservation District is "planned_community" in the env and "PC" on the site
  • Special Coastal Risk District 1 is "CR-1" in the env but there is only an anchor link to all of the coastal risk districts "CR"

I do not know where it is appropriate (the nyc.gov/planning site, the environment.js, or elsewhere in the ZoLa code) to make changes to resolve these discrepancies.

Closes #1274

@dhochbaum-dcp dhochbaum-dcp requested a review from a team as a code owner August 25, 2025 20:12
@netlify
Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for labs-zola ready!

Name Link
🔨 Latest commit 8a5e927
🔍 Latest deploy log https://app.netlify.com/projects/labs-zola/deploys/68b09d44ff8b450008990da5
😎 Deploy Preview https://deploy-preview-1277--labs-zola.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@TangoYankee
Copy link
Member

I do not know where it is appropriate (the nyc.gov/planning site, the environment.js, or elsewhere in the ZoLa code) to make changes to resolve these discrepancies.

@TylerMatteo, do you or any product owners have thoughts on these discrepencies?

@TylerMatteo
Copy link
Contributor

@dhochbaum-dcp For those discrepancies, you should make changes to the environment.js file. If there are any cases where you can't accommodate the new anchors by only changing that file, then you can change logic elsewhere in the Zola code.

@TylerMatteo
Copy link
Contributor

* Special Coastal Risk District 1 is "CR-1" in the env but there is only an anchor link to all of the coastal risk districts "CR"

For this, you can just link all of them to "CR" anchor.

@dhochbaum-dcp dhochbaum-dcp merged commit 6d4a73f into develop Aug 28, 2025
5 of 7 checks passed
@dhochbaum-dcp dhochbaum-dcp deleted the 1274-Update-links-on-Zola branch August 28, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update links on Zola

4 participants