Skip to content

Fix redirect content validation #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix redirect content validation #158

wants to merge 10 commits into from

Conversation

@nezlobnaya
Copy link
Contributor

@nezlobnaya nezlobnaya commented Nov 4, 2025 •
edited
Loading

Key Changes:

  • Refactored GetStatus()
  • Splits request logic into two phases:
  • HEAD probe — validates status and Location header without following redirects.
  • GET request — follows all redirects and validates final content (if ExpectedContent is set).
  • Added detailed debug logging for redirects.
  • Improved comparison helpers
  • failureString() now uses compareLocations() instead of raw equality for API consistency.
  • Added richer comments to compareLocations().
  • Defensive nil checks in performHeadRequest().
  • Ensures statusContentOk is computed once upstream and passed through cleanly.

Resolves #156

@nezlobnaya
Refactor constants and improve function signatures for clarity
9df2258
@nezlobnaya
Enhance compareLocations function to handle URL parsing and improve l…
6eb3923 
…ocation comparison logic
@nezlobnaya
Refactor GetStatus method to enhance HTTP request handling and improv…
28588b2 
…e debug logging
@nezlobnaya
Remove unused getClientUrl function to clean up code
4990ef3
@nezlobnaya
Refactor performGetRequest to use the application's URL directly and …
02001fc 
…improve error handling
@nezlobnaya
Improve error handling in performHeadRequest by checking response and…
f0e4d32 
… body before closing
@nezlobnaya
Refactor createApplicationStatus to improve error logging and streaml…
648ec71 
…ine content status checks
@nezlobnaya
Refactor failureString to use comparison functions for API consistency
def1ad5
@nezlobnaya
Enhance TestCreateApplicationStatus to include status content validat…
be0e4dd 
…ion and improve error handling
@nezlobnaya nezlobnaya mentioned this pull request Nov 4, 2025
Open
@nezlobnaya nezlobnaya force-pushed the fix/redirect-content-validation branch from 1a78fa6 to 2b60644 Compare November 10, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix redirect + content validation logic for Application checks

2 participants

@nezlobnaya