FIX: Restore map editing for non-admin roles (#452) - #456
Merged
Conversation
The editHtml permission check (CVE-2024-47090) was applied to every map modification, blocking roles like Managers from editing maps at all. Scope it to changes of HTML fields (textbox text), and keep the current value as a hidden field so objects can still be saved/moved unchanged. Fixes #452
LarsMichelsen
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XSS mitigation for the WYSIWYG editor (CVE-2024-47090) added an
editHtmlpermission check at the top ofhandleAddModify(), which runs for every map object save. As a result, roles without that permission (e.g. Managers) could no longer edit maps at all — adding a host, service or icon failed with "Cannot edit HTML. Please contact your administrator".This scopes the check to submissions that actually change an HTML field (the textbox
text, field typetextarea), comparing the submitted value against the stored one. Regular map editing works again without the permission, while changing HTML content still requireseditHtml.textarea()now also keeps the current value in a hidden field so a textbox can be moved/resized and saved unchanged.Fixes #452